STYLE: upgrade ruff #52974
Merged
STYLE: upgrade ruff #52974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still some errors. On the latest version of ruff, codes like will raises Meanwhile, if we just spilt the lines like It will be revised automatically by the black hook. |
Closed
MarcoGorelli
suggested changes
Apr 28, 2023
Comment on lines
846
to
848
| match = r"(No such file or directory|没有那个文件或目录|File o directory non esistente)" | ||
| match = ( | ||
| r"(No such file or directory|没有那个文件或目录|" r"File o directory non esistente)" | ||
| ) |
There was a problem hiding this comment.
you can write this one as something like
match = '|'.join([
"No such file or directory",
"没有那个文件或目录",
"File o directory non esistente",
])(with black's reformatting)
pandas/core/frame.py
Outdated
| lama speed 45.0 30.0 | ||
| llama speed 45.0 30.0 |
There was a problem hiding this comment.
these aren't aligned anymore
I'd suggest either:
- anytime you change lama to llama, fixup the alignment
- or, just keep the
codespellupdate out of this PR
.pre-commit-config.yaml
Outdated
| @@ -79,12 +79,12 @@ repos: | |||
| '--filter=-readability/casting,-runtime/int,-build/include_subdir,-readability/fn_size' | |||
| ] | |||
| - repo: https://github.com/pycqa/pylint | |||
| rev: v2.16.2 | |||
| rev: v3.0.0a6 | |||
There was a problem hiding this comment.
looks like pylint have pushed a new tag, but no new release. I'd suggest reverting this change for now
twoertwein
reviewed
Apr 28, 2023
MarcoGorelli
suggested changes
May 2, 2023
.pre-commit-config.yaml
Outdated
| @@ -79,12 +79,12 @@ repos: | |||
| '--filter=-readability/casting,-runtime/int,-build/include_subdir,-readability/fn_size' | |||
| ] | |||
| - repo: https://github.com/pycqa/pylint | |||
| rev: v2.16.2 | |||
| rev: v3.0.0a6 | |||
pandas/core/frame.py
Outdated
| lama speed 45.0 30.0 | ||
| llama speed 45.0 30.0 |
=1.5
Outdated
| @@ -0,0 +1,6 @@ | |||
| Requirement already satisfied: pandas in /home/yusharthsingh/Desktop/pandas (0+untagged.32262.g3790452.dirty) | |||
MarcoGorelli
reviewed
May 2, 2023
MarcoGorelli
suggested changes
May 2, 2023
twoertwein
approved these changes
May 2, 2023
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
* Bug: fix pre-commit problems * fix some errors * pre commit issues passed * Delete =1.5 * pytlint and alignment issue * fix errors * fix aligned and update ruff * Update pandas/core/series.py --------- Co-authored-by: yusharth <yusharthsingh@gmail.com> Co-authored-by: Yusharth Singh <57184245+yusharth@users.noreply.github.com> Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* Bug: fix pre-commit problems * fix some errors * pre commit issues passed * Delete =1.5 * pytlint and alignment issue * fix errors * fix aligned and update ruff * Update pandas/core/series.py --------- Co-authored-by: yusharth <yusharthsingh@gmail.com> Co-authored-by: Yusharth Singh <57184245+yusharth@users.noreply.github.com> Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* Bug: fix pre-commit problems * fix some errors * pre commit issues passed * Delete =1.5 * pytlint and alignment issue * fix errors * fix aligned and update ruff * Update pandas/core/series.py --------- Co-authored-by: yusharth <yusharthsingh@gmail.com> Co-authored-by: Yusharth Singh <57184245+yusharth@users.noreply.github.com> Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.